gtully commented on code in PR #4904:
URL: https://github.com/apache/activemq-artemis/pull/4904#discussion_r1575949383


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/config/PersistedSecuritySetting.java:
##########
@@ -252,8 +252,12 @@ public void decode(final ActiveMQBuffer buffer) {
       browseRoles = buffer.readNullableSimpleString();
       createAddressRoles = buffer.readNullableSimpleString();
       deleteAddressRoles = buffer.readNullableSimpleString();
-      viewRoles = buffer.readNullableSimpleString();

Review Comment:
   darn, I read the method readNullableSimpleString as doing the check for an 
non existent value, my bad,



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to