cshannon commented on PR #1207: URL: https://github.com/apache/activemq/pull/1207#issuecomment-2073017418
I only took a quick glance but 2 things stand out to me immediately that are issues: 1. The current PR is using recoverNextMessages() which changes state of the cursor, so this definitely won't work in an online broker without breaking the queue if the intent is for a user to use this to export while a broker is online. 2. This scans through the index and just skips when you could just use MessageOrderIndex with the order iterator and skip ahead by setting the batch location on the index This needs a bit more context with use cases to see how this is intended to be used to probably know the best way of doing some of this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
