jbertram commented on code in PR #4944:
URL: https://github.com/apache/activemq-artemis/pull/4944#discussion_r1617897308
##########
artemis-server/src/main/resources/schema/artemis-configuration.xsd:
##########
@@ -4913,6 +4913,14 @@
</xsd:annotation>
</xsd:element>
+ <xsd:element name="security-caches" type="xsd:boolean"
default="false" maxOccurs="1" minOccurs="0">
Review Comment:
The instances of Caffeine caches which are related to security is what is
being instrumented here. Metrics that are made available when this is set to
`true` are things like:
- `cache.size`
- `cache.puts`
- `cache.gets` tagged by `result` - either `hit` or `miss`
- `cache.evictions`
- `cache.eviction.weight`
Therefore, calling it `security-caches` seems appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
