gemmellr commented on PR #4960: URL: https://github.com/apache/activemq-artemis/pull/4960#issuecomment-2154908286
Your Jira and PR comments are aimed at Acceptor behaviour, and you note on the Jira that you are using Openwire clients...however the changed bits are also used by the Artemis Core client. I'm not familiar with this code, but it seems to me like the change could result in the connectionDestroyed listener callback being called for clients when it wouldnt currently be, after the connectionException listener callback could already have been called, potentially causing a double-failover or other weirdness? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
