kenliao94 commented on PR #1251: URL: https://github.com/apache/activemq/pull/1251#issuecomment-2223492085
> I'm mostly -1 on this change. > > I think this should be handled by configuring a filter at the logging framework level. > > Some users may want body redacted, others certain header or properties fields.. or even just specific fields within the body. > > Logging frameworks support configurable filters for this, I think this can be handled as a FAQ in ActiveMQ about how to add a logging filter. Hi Matt, thanks for the feedback. That's a good idea. Let me look into it today. Instead of making this change, we will ship a default configuration for audit log to mask that information and add a FAQ in ActiveMQ to instruct users on how to add their own or override the default. Does it sound good to you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
