jbertram commented on code in PR #4996:
URL: https://github.com/apache/activemq-artemis/pull/4996#discussion_r1676449586
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/bridge/BridgeTest.java:
##########
@@ -2084,6 +2085,108 @@ public void testManagementLeak() throws Exception {
assertEquals(0,
server.getManagementService().getResources(BridgeControl.class).length);
}
+ @TestTemplate
+ public void testWaitForPendingAcksOnStop() throws Exception {
+ testPendingAcks(true, false);
+ }
+
+ @TestTemplate
+ public void testWaitForPendingAcksOnPause() throws Exception {
+ testPendingAcks(false, false);
+ }
+
+ @TestTemplate
+ public void testWaitForPendingAcksOnStopWithLargeMessages() throws
Exception {
+ testPendingAcks(true, true);
+ }
+
+ @TestTemplate
+ public void testWaitForPendingAcksOnPauseWithLargeMessages() throws
Exception {
+ testPendingAcks(false, true);
+ }
+
+ private void testPendingAcks(boolean stop, boolean large) throws Exception {
Review Comment:
Added a handful of new tests for this use-case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
