gemmellr commented on PR #12: URL: https://github.com/apache/activemq-artemis-examples/pull/12#issuecomment-2228802863
Issues are raised in the ARTEMIS Jira project, just like the main codebase, as noted in [CONTRIBUTING.md](https://github.com/apache/activemq-artemis-examples/blob/main/CONTRIBUTING.md#contributing) Definitely wont merge this change since it isnt correct, the repo does not cover all versions. It was created originally targeting 2.31.2 in late 2023 (it was incrementally populated with the examples code starting from 2.28.0 onward mainly just to show nearly ~ 1 year of recent examples evolution at the time for developers looking at recent history as reminder) a bit prior to 2.32.0 and incorporating some development changes already made toward / needed for 2.32.0 examples. It is primarily aimed at the current released version (main branch), and changes toward the next version prior to release (development branch). We dont tend to update examples post release so other branches dont really make sense. History on the branches does show prior changes for previous specific versions, which are pretty easy to find in the history given the log message on update and minimal or no other changes between versions. I guess we can tag them anyway while updating the branches at release though, added to the helper script in https://github.com/apache/activemq-artemis-examples/commit/c6ce24402633c7a788531fe9ffbe23dcc0a59343 (also manually created tags to coincide with prior releases). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
