jbertram commented on code in PR #5092:
URL: https://github.com/apache/activemq-artemis/pull/5092#discussion_r1680003308
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/replication/ReplicationEndpoint.java:
##########
@@ -831,8 +830,8 @@ private void handlePageEvent(final
ReplicationPageEventMessage packet) throws Ex
private void handlePageWrite(final ReplicationPageWriteMessage packet)
throws Exception {
PagedMessage pgdMessage = packet.getPagedMessage();
pgdMessage.initMessage(storageManager);
- Message msg = pgdMessage.getMessage();
- Page page = getPage(msg.getAddressSimpleString(),
packet.getPageNumber());
+ SimpleString address = packet.getAddress();
+ Page page = getPage(address, packet.getPageNumber());
Review Comment:
nitpick...could be just:
```java
Page page = getPage(packet.getAddress(), packet.getPageNumber());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact