tabish121 commented on code in PR #5103:
URL: https://github.com/apache/activemq-artemis/pull/5103#discussion_r1684798818
##########
artemis-dto/src/main/java/org/apache/activemq/artemis/dto/WebServerDTO.java:
##########
@@ -107,6 +107,9 @@ public class WebServerDTO extends ComponentDTO {
@XmlAttribute
public Integer scanPeriod;
+ @XmlAttribute
+ public Integer requestHeaderSize;
Review Comment:
My only comment here is that this attribute name, while matching the
HttpConfiguration type's value isn't exactly self documenting as it doesn't
really convey it is a limit unlike the other options in this DTO. I'd have
gone with something like requestHeaderSizeLimit or maxRequestHeaderSize just so
it conveys the intent more clearly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
