clebertsuconic commented on code in PR #5091: URL: https://github.com/apache/activemq-artemis/pull/5091#discussion_r1690102571
########## artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionImpl.java: ########## @@ -712,6 +712,19 @@ private synchronized void activate() throws Exception { serverLocator.start(server.getExecutorFactory().getExecutor()); } + // add security role to disallow send/edit directly to sf queues + if (server.getConfiguration().isSecurityEnabled()) { + Set<Role> roles = new HashSet<>(); + String addressMatch = storeAndForwardPrefix + name + "." + server.getConfiguration().getWildcardConfiguration().getSingleWordString(); Review Comment: @gtully I was going to merge it now.. but it seems you still have some things to discuss on this one. i will skip this one from the next apache artemis release I'm doing... it will be in the next one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact