jbertram commented on PR #4966: URL: https://github.com/apache/activemq-artemis/pull/4966#issuecomment-2265739332
Generally speaking I think this looks good. However, there's a couple of things I would revisit: 1. The name `intermediate-message-buffer-initial-size`, while technically accurate, is probably not terribly clear to users. I think something like `initial-queue-buffer-size` is more clear. 2. The documentation defines this as the " initial number of elements of the intermediate message reference buffer." Again, this is technically accurate, but it doesn't give users a clear reason _why_ they might want to configure it. The docs should make clear that this is tied directly to the number of _bytes_ from the JVM's heap each queue will consume initially. The docs might also mention the canonical use-case for this (i.e. lots of queues which might remain empty or have a small number of messages). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
