andytaylor commented on code in PR #21:
URL: 
https://github.com/apache/activemq-artemis-console/pull/21#discussion_r1714021202


##########
artemis-console-extension/artemis-extension/public/artemisconfig.json:
##########
@@ -0,0 +1,5 @@
+{
+    "jmx": {
+      "domain": "org.apache.activemq.artemis"
+    }
+}

Review Comment:
   > Is there some validation done in the pipelline at some point? I'm thinking 
about a jsonschema of some sort.
   
   There isn't, tbh I took this code from hawtIO, it is how they do it with 
hawtconfig.json. I wouldnt know how to do whatyou suggest tbh.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to