gemmellr commented on code in PR #5145:
URL: https://github.com/apache/activemq-artemis/pull/5145#discussion_r1716531121


##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/Channel.java:
##########
@@ -57,6 +57,14 @@ public interface Channel {
     */
    boolean supports(byte packetID, int version);
 
+   /*
+    * Due to ARTEMIS-4986, older versions (2.30.0 in particular) will require 
a special voting handling,

Review Comment:
   The cause of ARTEMIS-4986, ARTEMIS 3474, was introduced in 2.32.0 so as 
noted before I don't understand the references to 2.30.0. The vote string 
mismatch issue would apply between versions <= 2.31.2 and versions 
2.32.0-2.36.0.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to