gemmellr commented on code in PR #5128:
URL: https://github.com/apache/activemq-artemis/pull/5128#discussion_r1718128177
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java:
##########
@@ -232,7 +233,7 @@ private void configureSizeMetric() {
* @param addressSettings
*/
@Override
- public void applySetting(final AddressSettings addressSettings) {
+ public void applySetting(final AddressSettings addressSettings, final
boolean firstTime) {
Review Comment:
Since it is really an implementation detail that the constructor calls the
applySetting method, I think this interface method should probably just go
back to the way it was, and a private internal second method be created with
the firstTime boolean that both this methods implementation and the constructor
can then call. That way the interface and none of the tests etc need to be
updated to support calling with false (and they shouldnt be able to call with
true)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
