gemmellr commented on code in PR #5173:
URL: https://github.com/apache/activemq-artemis/pull/5173#discussion_r1735021832
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPConnectionContext.java:
##########
@@ -198,6 +203,18 @@ public AMQPConnectionContext(ProtonProtocolManager
protocolManager,
}
}
+ public List<AMQPMirrorControllerTarget> getMirrorControllerTargets() {
+ return mirrorControllerTargets;
+ }
+
+ public AMQPConnectionContext
addMirrorControllerTarget(AMQPMirrorControllerTarget mirrorControllerTarget) {
+ if (mirrorControllerTargets == null) {
+ mirrorControllerTargets = new ArrayList<>();
+ }
+ mirrorControllerTargets.add(mirrorControllerTarget);
Review Comment:
Assuming the connection does close. This is for a specific sender that could
itself go away for other reasons. There was just another PR yesterday for
handling that it _didnt_ recreate the sender or close the connection in some
such cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
