tabish121 commented on PR #1290: URL: https://github.com/apache/activemq/pull/1290#issuecomment-2315963408
Change seems reasonable to me. The idea that you need to change the openwire bits might be going to far given the expectation is that those bits are using modified UTF8 and has been for ages. What really matters is the protocols on the periphery which are less likely to be expecting modified UTF8 vs the standard UTF8 encoding like AMQP. For AMQP the proton-j bits will be doing that work to encode and decode and should only be populating the ActiveMQ message types with the decoded String content on ingress and then encoding the Strings from TextMessage and message properties as they move out of the broker (If the transformer is configured to 'jms'). For MQTT the protocol is a binary encoding and as far as I'm aware there is nothing internal that's creating TextMessage views of those MQTT messages so that should be safe (probably want to check for some weird option that does though). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
