gemmellr commented on PR #5198: URL: https://github.com/apache/activemq-artemis/pull/5198#issuecomment-2324495151
The API doc for the createSession method(s) does not say null return is even a possibility. If it is then it should really be mentioned as expected behaviour, especially as it is kinda weird in this case; create methods like that usually throw (which is what is implied by the doc if anything...though with the wiggle room that an exception 'did not occur' here...but only because the code chose not to throw when deciding it failed). Given the cause and effect and fix is the same and its all in the same method, this seems like one change to me rather than two separate changes. I'd either reference both Jiras in one commit, or update the description of one Jira and drop the other. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
