tabish121 commented on code in PR #5220:
URL: https://github.com/apache/activemq-artemis/pull/5220#discussion_r1747678619


##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerTarget.java:
##########
@@ -512,6 +521,12 @@ private boolean sendMessage(Message message, 
DeliveryAnnotations deliveryAnnotat
 
       routingContext.setDuplicateDetection(false); // we do our own duplicate 
detection here
 
+      if (noForward) {

Review Comment:
   If getting to this point the message isn't sent then it would be good to tie 
a bow on the logging that has occurred to this point and log a trace level 
message indicating what happened.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to