ldauvilaire commented on PR #5207:
URL: 
https://github.com/apache/activemq-artemis/pull/5207#issuecomment-2341582864

   @jbertram : yes it works, there are NullPointerException followed by 
IllegalStateException on the server side, but it works.
   client side logs :
   
   > o.a.a.t.f.FailoverTransport Successfully connected to 
ssl://localhost:62617?verifyHostName=false&soTimeout=30000&soWriteTimeout=30000&keepAlive=true
   >
   > o.a.a.t.f.FailoverTransport Transport 
(ssl://localhost:62617?verifyHostName=false&soTimeout=30000&soWriteTimeout=30000&keepAlive=true)
 failed, attempting to automatically reconnect: java.io.EOFException
           at java.io.DataInputStream.readInt(DataInputStream.java:392)
           at 
org.apache.activemq.openwire.OpenWireFormat.unmarshal(OpenWireFormat.java:280)
           at 
org.apache.activemq.transport.tcp.TcpTransport.readCommand(TcpTransport.java:240)
           at 
org.apache.activemq.transport.tcp.TcpTransport.doRun(TcpTransport.java:232)
           at 
org.apache.activemq.transport.tcp.TcpTransport.run(TcpTransport.java:215)
           at java.lang.Thread.run(Thread.java:750)
   >
   > o.a.a.t.f.FailoverTransport Failed to connect to 
[ssl://localhost:62617?verifyHostName=false&soTimeout=30000&soWriteTimeout=30000&keepAlive=true]
 after: 1 attempt(s) with Connection refused (Connection refused), continuing 
to retry.
   >
   > o.a.a.t.f.FailoverTransport Failed to connect to 
[ssl://localhost:62617?verifyHostName=false&soTimeout=30000&soWriteTimeout=30000&keepAlive=true]
 after: 10 attempt(s) with Connection refused (Connection refused), continuing 
to retry.
   >
   > o.a.a.t.f.FailoverTransport Successfully reconnected to 
ssl://localhost:62617?verifyHostName=false&soTimeout=30000&soWriteTimeout=30000&keepAlive=true
   
   
   
   
   @mattrpav : the change is in the configuration of the 
PooledConnectionFactory on the client side.
   that's manageable on the client side.
   
   I can suggest an improvement on the **artemis-jms-pool** in class 
**ConnectionPool** on method **onException**
   to always close the connection in case of **JMSSecurityException**.
   replacing
   ```
      @Override
       public void onException(JMSException exception) {
           if (isReconnectOnException()) {
               close();
           }
           if (parentExceptionListener != null) {
               parentExceptionListener.onException(exception);
           }
       }
   ```
   by
   ```
       @Override
       public void onException(JMSException exception) {
           if (isReconnectOnException() || (exception instanceof 
JMSSecurityException)) {
               close();
           }
           if (parentExceptionListener != null) {
               parentExceptionListener.onException(exception);
           }
       }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to