jbonofre commented on code in PR #1247:
URL: https://github.com/apache/activemq/pull/1247#discussion_r1753744765
##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/virtual/BaseVirtualDestinationFilter.java:
##########
@@ -0,0 +1,23 @@
+package org.apache.activemq.broker.region.virtual;
Review Comment:
The ASF header is missing here.
##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/virtual/BaseVirtualDestinationFilter.java:
##########
@@ -0,0 +1,23 @@
+package org.apache.activemq.broker.region.virtual;
+
+import org.apache.activemq.broker.region.BaseDestination;
+import org.apache.activemq.broker.region.Destination;
+import org.apache.activemq.broker.region.DestinationFilter;
+
+import java.util.Optional;
+
+public class BaseVirtualDestinationFilter extends DestinationFilter {
+
+ public BaseVirtualDestinationFilter(Destination next) {
+ super(next);
+ }
+
+ Optional<BaseDestination> getBaseDestination(Destination virtualDest) {
Review Comment:
I don't think we should use `Optional` here. I would rather check the base
object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
