clebertsuconic commented on code in PR #5232:
URL: https://github.com/apache/activemq-artemis/pull/5232#discussion_r1758878546
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java:
##########
@@ -1136,7 +1136,16 @@ private void sendContinuations(final int packetSize,
currentLargeMessage = null;
try {
- session.send(session.getCurrentTransaction(),
EmbedMessageUtil.extractEmbedded((ICoreMessage) message.toMessage(),
storageManager), false, producers.get(senderID), false);
+ Message m = EmbedMessageUtil.extractEmbedded((ICoreMessage)
message.toMessage(), storageManager);
Review Comment:
shouldn't the fix be to actually keep the message as large instead?
say, if you look here:
https://github.com/apache/activemq-artemis/blob/257dd86ae28205d8ad57314cbe1cf8b17659aea5/artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/protocol/EmbedMessageUtil.java#L78-L79
we could check on EMBEDDED_TYPE:
if (message.isLargeMessage) then perform the extractLargeMessage
or the encoded version wouldn't be compatible in that case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
