kenliao94 commented on PR #1303: URL: https://github.com/apache/activemq/pull/1303#issuecomment-2353465737
> Although this is only a first iteration (or second, if counting the earlier PR), it feels like you didnt actually read the spec when implementing the methods, or the feedback on the previous PR (i.e. [#1045 (comment)](https://github.com/apache/activemq/pull/1045#issuecomment-1699645592)) as you commented on it. There are multiple places this is obviously not implementing required behaviours. > Hi @gemmellr, thank you so much for the feedback, really appreciate you highlighting the problems of this PR. I was reading the specs and looking into that comment after reviewing Matt's closed PR.I did realize it has more nuances (as said tabish121's comment that you linked). The reason why I wanted to raise this draft pr (not meant to be reviewed) is to link it and showed that I have tried it and likely it's missing things too. In hindsight, I should make it more explicit on the title. I will address your comments in a follow up PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
