gemmellr commented on code in PR #31: URL: https://github.com/apache/activemq-artemis-console/pull/31#discussion_r1763418749
########## Releasing.md: ########## @@ -0,0 +1,152 @@ +## Generating the licenses for the NPM dependencies + +Before a release can be performed the npm license need to be updated with any new dependencies. This file is found under `artemis-console-distribution/src/main/resources/licenses/NPMLicenses.txt`. Review Comment: ```suggestion Before a release can be performed the npm license need to be updated with any new dependencies. This file is found under `artemis-console-distribution/src/main/resources/licenses/licenses/NPMLicenses.txt`. ``` ########## Releasing.md: ########## @@ -0,0 +1,152 @@ +## Generating the licenses for the NPM dependencies + +Before a release can be performed the npm license need to be updated with any new dependencies. This file is found under `artemis-console-distribution/src/main/resources/licenses/NPMLicenses.txt`. + +This is done using the NPM [yarn-plugin-licenses](https://github.com/mhassan1/yarn-plugin-licenses) plugin, you will need to install this if you havent already. Review Comment: The .yarnrc file has an entry for this, so is this true at this point? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
