gemmellr commented on code in PR #5254:
URL: https://github.com/apache/activemq-artemis/pull/5254#discussion_r1774929556


##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/StompTest.java:
##########
@@ -2120,4 +2120,54 @@ public void 
testSameMessageHasDifferentMessageIdPerConsumer() throws Exception {
       conn.disconnect();
    }
 
+   @Test
+   public void testMultipleSubscriptionsOnMulticastAddressReadSameMessage() 
throws Exception {
+      doTestMultipleSubscriptionsOnMulticastAddressReadSameMessage(10);
+   }
+
+   @Test
+   public void 
testMultipleSubscriptionsOnMulticastAddressReadSameLargeMessage() throws 
Exception {
+      doTestMultipleSubscriptionsOnMulticastAddressReadSameMessage(120_000);
+   }
+
+   private void 
doTestMultipleSubscriptionsOnMulticastAddressReadSameMessage(int size) throws 
Exception {
+      final String body = "A".repeat(size);
+
+      final StompClientConnection conn_r1 = 
StompClientConnectionFactory.createClientConnection(uri);
+      final StompClientConnection conn_r2 = 
StompClientConnectionFactory.createClientConnection(uri);
+
+      try {
+         conn_r1.connect(defUser, defPass);
+         subscribeTopic(conn_r1, null, null, null);
+
+         conn_r2.connect(defUser, defPass);
+         subscribeTopic(conn_r2, null, null, null);
+
+         // Sender
+         conn.connect(defUser, defPass);
+         send(conn, getTopicPrefix() + getTopicName(), null, body, true, 
RoutingType.MULTICAST);
+
+         ClientStompFrame frame1 = conn_r1.receiveFrame(10000);
+         ClientStompFrame frame2 = conn_r2.receiveFrame(10000);
+
+         assertEquals(Stomp.Responses.MESSAGE, frame2.getCommand());
+         assertEquals(Stomp.Responses.MESSAGE, frame1.getCommand());
+
+         assertEquals(getTopicPrefix() + getTopicName(), 
frame2.getHeader(Stomp.Headers.Send.DESTINATION));
+         assertEquals(getTopicPrefix() + getTopicName(), 
frame1.getHeader(Stomp.Headers.Send.DESTINATION));
+
+         assertEquals(RoutingType.MULTICAST.toString(), 
frame2.getHeader(Stomp.Headers.Send.DESTINATION_TYPE));
+         assertEquals(RoutingType.MULTICAST.toString(), 
frame1.getHeader(Stomp.Headers.Send.DESTINATION_TYPE));
+
+         
assertTrue(frame2.getHeader(org.apache.activemq.artemis.api.core.Message.HDR_ROUTING_TYPE.toString())
 == null);
+         
assertTrue(frame1.getHeader(org.apache.activemq.artemis.api.core.Message.HDR_ROUTING_TYPE.toString())
 == null);

Review Comment:
   assertNull ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to