gemmellr commented on code in PR #5220:
URL: https://github.com/apache/activemq-artemis/pull/5220#discussion_r1778266549
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerSource.java:
##########
@@ -236,6 +238,10 @@ public void deleteAddress(AddressInfo addressInfo) throws
Exception {
if (ignoreAddress(addressInfo.getName())) {
return;
}
+ if (isBlockedByNoForward()) {
+ return;
+ }
+
Review Comment:
I would do this earlier; no point checking the specific address is permitted
(the bit above) if we aren't allowed to forward it _anywhere_.
Same for other bits further down
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
