gemmellr commented on code in PR #5288:
URL: https://github.com/apache/activemq-artemis/pull/5288#discussion_r1793451371
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
##########
@@ -2550,6 +2552,11 @@ public boolean isExpirationRedundant() {
return true;
}
+ if (isInternalQueue() && name.toString().startsWith(MIRROR_ADDRESS)) {
+ logger.trace("Mirrored queues are not supposed to expiry. Address={},
Queue={}", address, name);
Review Comment:
This also doesnt seem to align with the PR title. This only affects mirror
SnF queues, but the PR title is that the change is for "MirrorSNF and other
internal queues".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
