tabish121 commented on code in PR #5291: URL: https://github.com/apache/activemq-artemis/pull/5291#discussion_r1796067224
########## artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java: ########## @@ -1298,6 +1298,18 @@ public ServerLocatorImpl setInitialMessagePacketSize(final int size) { return this; } + @Override + public int getOnMessageCloseTimeout() { + return config.onMessageCloseTimeout; + } + + @Override Review Comment: The API docs specify the value set must be greater than zero, but there isn't any validation of that, should there be? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact