brusdev commented on code in PR #5289:
URL: https://github.com/apache/activemq-artemis/pull/5289#discussion_r1801594707
##########
artemis-distribution/src/main/assembly/dep.xml:
##########
@@ -72,9 +72,18 @@
<includes>
<include>org.apache.activemq:artemis-console:war</include>
</includes>
- <outputDirectory>web</outputDirectory>
- <unpack>false</unpack>
- <outputFileNameMapping>console.war</outputFileNameMapping>
+ <outputDirectory>web/console.war</outputDirectory>
+ <unpack>true</unpack>
+ <!-- Exclude these jar files from console since they are already
provided in the broker distribution.
+ If any of these jars is dropped from the broker distribution
they should be added back to the console. -->
+ <unpackOptions>
+ <excludes>
+ <exclude>**/guava*.jar</exclude>
+ <exclude>**/commons-io*.jar</exclude>
+ <exclude>**/commons-logging*.jar</exclude>
+ <exclude>**/failureaccess*.jar</exclude>
+ </excludes>
+ </unpackOptions>
Review Comment:
It LGTM and the exploded war provides an easy way to customize files like
web.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
