mattrpav commented on code in PR #1288: URL: https://github.com/apache/activemq/pull/1288#discussion_r1812920078
########## activemq-broker/src/main/java/org/apache/activemq/broker/jmx/BrokerViewMBean.java: ########## @@ -179,9 +179,17 @@ public interface BrokerViewMBean extends Service { @MBeanInfo("Topics (broadcasted 'queues'); generally system information.") ObjectName[] getTopics(); + @MBeanInfo("Total number of topics") + int getTotalTopicsCount(); + + @MBeanInfo("Standard Queues containing AIE messages.") ObjectName[] getQueues(); + @MBeanInfo("Total number of queues") + int getTotalQueuesCount(); + + Review Comment: There are 4 total sets of destinations -- Queues, Topics, TempQueues and TempTopics. If we are adding the metric for TotalQueueCount and TotalTopicCount, we should also add TotalTempQueueCount and TotalTempTopicCount. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact