tabish121 commented on code in PR #5316:
URL: https://github.com/apache/activemq-artemis/pull/5316#discussion_r1813223555
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java:
##########
@@ -2618,6 +2618,60 @@ public void testMoveMessage() throws Exception {
session.deleteQueue(otherQueue);
}
+ @TestTemplate
Review Comment:
For adding a feature like this you should ideally write a test that covers
more of the protocols and messages (normal or large) as well as times when
paging is happening vs not as there have been a number of cases lately where a
breakage or misbehavior has been found when an AMQP or a Large message was
involved in internal management code such as this.
Refer to test:
[tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/plugin/BeforeSendPluginTest.java](https://github.com/apache/activemq-artemis/blob/24fb38c86f5367865741e2fdea5773ec41da0685/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/plugin/BeforeSendPluginTest.java)
for some inspiration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
