mattrpav commented on code in PR #1288:
URL: https://github.com/apache/activemq/pull/1288#discussion_r1813211735
##########
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/BrokerView.java:
##########
@@ -280,11 +280,21 @@ public ObjectName[] getTopics() {
return safeGetBroker().getTopicsNonSuppressed();
}
+ @Override
+ public int getTotalTopicsCount() {
+ return getTopics().length;
+ }
+
@Override
public ObjectName[] getQueues() {
return safeGetBroker().getQueuesNonSuppressed();
}
+ @Override
+ public int getTotalQueuesCount() {
+ return getQueues().length;
Review Comment:
getQueues() <-- returns ObjectName[], an array of JMX ObjectNames for queues
that are registered, this isn't _all queues in the broker_. If anything, this
method is mislabeled.
Use cases:
Use Case 1: 128 queues, no jmx mbean suppression
Use Case 2: 128 queues, 128 queues suppressed
Use Case 3: 128 queues, 28 queues suppressed
Current proposal:
| Use Case | # queues | # suppressed | getQueues() result |
getTotalQueueCount() |
| ------------- | ------------- | ------------- | ------------- |
------------- |
| 1 | 128 | 0 | 128 ObjectName[] | 128 |
| 2 | 128 | 128 | 0 ObjectName[] | 0 |
| 3 | 128 | 28 | 28 ObjectName[] | 28 |
mattrpav proposal:
Current proposal:
| Use Case | # queues | # suppressed | getQueues() result |
getTotalQueueCount() |
| ------------- | ------------- | ------------- | ------------- |
------------- |
| 1 | 128 | 0 | 128 ObjectName[] | 128 |
| 2 | 128 | 128 | 0 ObjectName[] | 128 |
| 3 | 128 | 28 | 28 ObjectName[] | 128 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
