gtully commented on code in PR #5340:
URL: https://github.com/apache/activemq-artemis/pull/5340#discussion_r1837983769
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java:
##########
@@ -834,7 +835,12 @@ public int getAddressMemoryUsagePercentage() {
@Override
public String getHAPolicy() {
- return configuration.getHAPolicyConfiguration().getType().getName();
+ HAPolicyConfiguration haConfig =
configuration.getHAPolicyConfiguration();
Review Comment:
should a default not be in the configuration rather than in the server
control.
I think primary only is a sensible default, but I would also expect an
embedded broker to provide configuration values that it cares about rather than
depend on defaults. Defaults will only cover some subset at some time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
