gemmellr commented on PR #5345: URL: https://github.com/apache/activemq-artemis/pull/5345#issuecomment-2476321804
Probably not that weird. This PR, and your PR, didnt have the problem commit on the source branches, so their jobs would work in the fork repos, and the build would work locally. You merged the other/earlier PR which broke main, just before these 2 PRs were raised/updated 1-commit-from-head. When the new PRs were raised they ran on the merge result against the main base branch, so those runs can then give a different result than local/fork runs when the source branches arent based at the head of main at the point the PRs are raised. I also upgraded Checkstyle a couple of days ago, so seems like there was perhaps also a change in its behavior inbetween your different runs on the problem PR spanning that update, which you would presumably have also brought in when rebasing and pushing. Basically doubly bad timing, and good example of 'just a simple rebase' still often needing at least a re-build if not re-test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
