tabish121 commented on PR #5355: URL: https://github.com/apache/activemq-artemis/pull/5355#issuecomment-2485862105
> I think we should still merge #5346 > > the close of the reader should be done before delivering the message, regardless. > > when I moved the close to finalize I thought it was about closing the file... as it stands that method should still be called before the actualDelivery. Since that change is essentially just a cosmetic change it is orthogonal to this and can be done if you want but will have no real effect on the underlying threading race that is occurring here as I've outlined previously. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
