mattrpav commented on code in PR #1355:
URL: https://github.com/apache/activemq/pull/1355#discussion_r1852309530
##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/cursors/AbstractStoreCursor.java:
##########
@@ -255,12 +255,20 @@ public synchronized boolean
tryAddMessageLast(MessageReference node, long wait)
disableCache = true;
}
- if (disableCache && isCacheEnabled()) {
+ // AMQ-9625 - use this.cacheEnabled directly because the method
isCacheEnabled() is overriden
+ // to try to re-enable the cache which we don't want at this point as
we already skipped
+ // adding it to the cache
+ if (disableCache && this.cacheEnabled) {
if (LOG.isTraceEnabled()) {
Review Comment:
Thoughts on follow-on JIRA to add a metric or state flag when this occurs?
Trace log is good for debugging, but when managing lots of brokers, its seems
this could be a good thing to bubble up so admins know it occurs or if it is
occurring frequently, some tuning may need to be required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
