gemmellr commented on PR #5359: URL: https://github.com/apache/activemq-artemis/pull/5359#issuecomment-2493863040
> @clebertsuconic @gemmellr Hope these changes are to your liking. > > For a future change I've also looked a bit into adding [command history](https://github.com/jline/jline3/wiki/History) Not really sure how to verify that properly though as I have no access to a Windows PC, but I think it should be fairly trivial to implement. > > Finally I'd also be interested in building this as a standalone tool and distribute it on the website, alongside the broker distribution and the native binaries. > > I've build this for my own purposes with `maven-assembly-plugin` added to the [artemis-cli](https://issues.apache.org/jira/browse/ARTEMIS-cli)/pom.xml but I suspect that might not be the best way to do it as part of building the project in its entirety. I also don't really know if just a jar file is "fine" to distribute or if we want additional packaging to make the tool as intuitive and user friendly as possible. > > Do you have any thoughts on this? I wouldn't be in favour of it personally. The CLI already depends on a large proportion of the broker distribution so there would be a significant overlap. Given the way they exist in the overall build and are typically used, the benefits of a standalone CLI distribution relly dont seem that significant to me to warrant actually maintaining such a thing. Some uses actively dont seem to make sense given their relation to the broker / instance configuration. Which makes me think..have I actually entirely misunderstood what you are asking about? The native bits for the journal only have their own downloads because they are actually released independently, infrequently, and so requires its own source assembly (the source is always the 'actual release'). The convenience binary is only there because its being built so the output can be consumed in the actual broker convenience binaries later during Artemis builds. Its off on its own sub-download page without any wider site component detail since its not really expected anyone actually needs to download it. Thoughts of a 'new' component distribution would also really be for discussion on the mailing list, rather than just a simple improvement PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
