Re: [PR] ARTEMIS-5037: option to limit mirror propagation [activemq-artemis]

[via GitHub]

lavocatt commented on code in PR #5220:
URL: https://github.com/apache/activemq-artemis/pull/5220#discussion_r1862305865


##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerSource.java:
##########
@@ -543,6 +602,17 @@ public void preAcknowledge(final Transaction tx, final 
MessageReference ref, fin
          logger.trace("preAcknowledge::tx={}, ref={}, reason={}", tx, ref, 
reason);
       }
 
+      SimpleString noForwardSource = null;
+      if 
(Boolean.TRUE.equals(ref.getMessage().getBooleanProperty(INTERNAL_NO_FORWARD))) 
{
+         noForwardSource = (SimpleString) 
ref.getMessage().getBrokerProperty(INTERNAL_NO_FORWARD_SOURCE);

Review Comment:
   Even though the value we set on the target is a String, it gets somehow 
turned into a SimpleString. If I try to cast that broker property to a string, 
I'm getting: `class org.apache.activemq.artemis.api.core.SimpleString cannot be 
cast to class java.lang.String`.
   
   On the target side I do send a String in the property:
   
![image](https://github.com/user-attachments/assets/78522d37-78b4-4a8b-a87f-5ca1dc736da4)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact