kenliao94 commented on code in PR #1358:
URL: https://github.com/apache/activemq/pull/1358#discussion_r1865242625
##########
activemq-broker/src/main/java/org/apache/activemq/security/SimpleCachedLDAPAuthorizationMap.java:
##########
@@ -936,7 +936,11 @@ public void namingExceptionThrown(NamingExceptionEvent
namingExceptionEvent) {
// Init / Destroy
public void afterPropertiesSet() throws Exception {
- query();
+ try {
+ query();
+ } catch (Exception e) {
+ LOG.error("Error updating authorization map. Partial policy may
be applied until the next successful update.", e);
Review Comment:
I would also include a string that suggest ways for the user to mitigate it.
Something like "The LDAP server might not be reachable, check ..." even tho the
root cause can be many reason. Because "authorization map" is an internal
concept, user might not get it and they don't know how to get themselves
unstuck. However, It needs to be phrase in such a way that this is one possible
root cause, but not necessarily THE root cause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
