mattrpav commented on code in PR #1329:
URL: https://github.com/apache/activemq/pull/1329#discussion_r1866676935


##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/DestinationStatistics.java:
##########
@@ -76,6 +87,17 @@ public DestinationStatistics() {
         networkEnqueues = new CountStatisticImpl("networkEnqueues", "The 
number of messages that have been sent to the destination via network 
connection");
         networkDequeues = new CountStatisticImpl("networkDequeues", "The 
number of messages that have been acknowledged from the destination via network 
connection");
 
+        enqueuedMessageBrokerInTime = new 
UnsampledStatisticImpl<>("enqueuedMessageBrokerInTime", "ms", "Broker in time 
(ms) of last enqueued message to the destination", Long.valueOf(0l));
+        enqueuedMessageClientID = new 
UnsampledStatisticImpl<>("enqueuedMessageClientID", "id", "ClientID of last 
enqueued message to the destination", null);
+        enqueuedMessageID = new UnsampledStatisticImpl<>("enqueuedMessageID", 
"id", "MessageID of last enqueued message to the destination", null);
+        enqueuedMessageTimestamp = new 
UnsampledStatisticImpl<>("enqueuedMessageTimestamp", "ms", "Message timestamp 
of last enqueued message to the destination", Long.valueOf(0l));
+
+        dequeuedMessageBrokerInTime = new 
UnsampledStatisticImpl<>("dequeuedMessageBrokerInTime", "ms", "Broker in time 
(ms) of last dequeued message to the destination", Long.valueOf(0l));

Review Comment:
   That’s a good idea. It’ll add a bit more logic to support dynamically 
enabling/disabling advanced statistics at runtime. 
   
   I’ll add that for both advanced message and network statistics. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to