clebertsuconic commented on PR #5384: URL: https://github.com/apache/activemq-artemis/pull/5384#issuecomment-2521709440
@jbertram I removed the testBase and I made it a test.. I guess it makes difficult to see the diffs... the main diff is this: https://github.com/apache/activemq-artemis/blob/3d196ad70c0a9db145fae003877950fc4e144077/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/RandomReattachIntegrationTest.java#L228-L253 there's a check of expectedException.... if it's an expected exception it will just skip and increase the numIts. I also closed the SessionFactory, and locators and stop the server since there was a leak between the tests. We could go further and just ignore any exception to an individualACK however that's not really wise.. since not that many people really use reattachment, and if this happens users should still treat it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
