gemmellr commented on PR #5390: URL: https://github.com/apache/activemq-artemis/pull/5390#issuecomment-2541643432
You mentioned adding more tests...this is one I actually do think should have integration tests as well. In particular, as I think about it more, I guess its likely there is a gotcha in there for AMQP messages (both for this and the existing min/max etc). I would not be surprised to see the broker apply the new expirations 'locally' but then send the original expiration to the consumer...so e.g if you _increase_ or _remove_ an original expiration, things may not turn out at all as intended. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
