brusdev commented on code in PR #5408:
URL: https://github.com/apache/activemq-artemis/pull/5408#discussion_r1891359006
##########
artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompConnection.java:
##########
@@ -566,7 +566,7 @@ StompPostReceiptFunction subscribe(String destination,
if (selector == null) {
selector = noLocalFilter;
} else {
- selector += " AND " + noLocalFilter;
+ selector = "(" + selector + ") AND " + noLocalFilter;
Review Comment:
could selector be an empty string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
