jbonofre commented on code in PR #1370:
URL: https://github.com/apache/activemq/pull/1370#discussion_r1892040169


##########
activemq-http/src/main/java/org/apache/activemq/transport/ws/WSTransportServer.java:
##########
@@ -96,7 +96,13 @@ protected void doStart() throws Exception {
 
         contextHandler.setAttribute("acceptListener", getAcceptListener());
 
-        server.start();
+        ClassLoader original = Thread.currentThread().getContextClassLoader();
+        
Thread.currentThread().setContextClassLoader(WSTransportServer.class.getClassLoader());

Review Comment:
   This could be problematic in OSGi/Karaf generally speaking. In this specific 
it should be ok as the `WSTransportServer` is in the `activemq-osgi` bundle.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to