gemmellr commented on code in PR #5431:
URL: https://github.com/apache/activemq-artemis/pull/5431#discussion_r1910521876
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/routing/RedirectTest.java:
##########
@@ -45,37 +45,30 @@
import org.apache.activemq.artemis.tests.extensions.parameterized.Parameters;
import org.apache.activemq.artemis.core.server.routing.KeyType;
import
org.apache.activemq.artemis.core.server.cluster.impl.MessageLoadBalancingType;
-import org.apache.activemq.artemis.tests.util.Wait;
import org.junit.jupiter.api.TestTemplate;
import org.junit.jupiter.api.extension.ExtendWith;
@ExtendWith(ParameterizedTestExtension.class)
public class RedirectTest extends RoutingTestBase {
+ static final String[] protocols = new String[] {AMQP_PROTOCOL,
CORE_PROTOCOL, OPENWIRE_PROTOCOL};
+ static final String[] pools = new String[] {CLUSTER_POOL, DISCOVERY_POOL,
STATIC_POOL};
@Parameters(name = "protocol: {0}, pool: {1}")
public static Collection<Object[]> data() {
- final String[] protocols = new String[] {AMQP_PROTOCOL, CORE_PROTOCOL,
OPENWIRE_PROTOCOL};
- final String[] pools = new String[] {CLUSTER_POOL, DISCOVERY_POOL,
STATIC_POOL};
Collection<Object[]> data = new ArrayList<>();
- for (String protocol : Arrays.asList(protocols)) {
- for (String pool : Arrays.asList(pools)) {
- data.add(new Object[] {protocol, pool});
- }
+ for (String pool : Arrays.asList(pools)) {
+ data.add(new Object[] {AMQP_PROTOCOL, pool});
Review Comment:
The comment timestamp is from when I originally made the comment, but I only
actually completed and posted my review moments before you did yours, i.e we
posted the reviews at essentially the same time (its only shown to the minute,
so both have same timestamp value).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
