gemmellr commented on code in PR #5430:
URL: https://github.com/apache/activemq-artemis/pull/5430#discussion_r1910545536
##########
tests/artemis-test-support/src/main/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java:
##########
@@ -545,7 +545,7 @@ protected static final ClusterConnectionConfiguration
basicClusterConnectionConf
setName("cluster1").setAddress("jms").setConnectorName(connectorName).
setRetryInterval(100).setDuplicateDetection(false).setMaxHops(1).
setConfirmationWindowSize(1).setMessageLoadBalancingType(MessageLoadBalancingType.STRICT).
- setStaticConnectors(connectors0);
+
setStaticConnectors(connectors0).setCallTimeout(1000).setCallFailoverTimeout(1000);
Review Comment:
Sure, but could it also mean that most tests are now set up in a non-typical
configuration, which might then mean we dont notice longer waits etc that
actually arent expected.
In general I think its nice for a test config to be as typical as it can,
changing only whats really needed for the specific test. Its a balance though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
