hailengc opened a new pull request, #1376:
URL: https://github.com/apache/activemq/pull/1376

   ### Problem 
   When ActiveMQ starts up with `./bin/activemq console`, there is double slash 
(`//`) shows in the output, example:
    
   *  ... Configurations are loaded in the following order: 
(omit...)/apache-activemq-6.2.0-SNAPSHOT//bin/setenv
   *  .... INFO: Creating pidfile  
(omit...)/apache-activemq-6.2.0-SNAPSHOT//data/activemq.pid
   *  ... -Dactivemq.classpath= (omit...)/apache-activemq-6.2.0-SNAPSHOT//conf
   
   
   ### Description of Change
   This fix uses  `Parameter Expansion` which is  a POSIX standard feature in 
shell ( reference 
[doc](https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_02))
 . The syntax  `"${ACTIVEMQ_BASE%/}/data"` meaning it removes the trailing `/` 
if  `$ACTIVEMQ_BASE` ends with a `/`, otherwise it does nothing.
   
   * Apply this to both  `$ACTIVEMQ_HOME` and `$ACTIVEMQ_BASE` where they are 
concatenated with sub path
   * Not touching anything regarding non-linx platform ("cygwin" )
   
   
   ### Test
   Running it locally and seeing no double slash in the path in the output.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to