tabish121 commented on code in PR #5448:
URL: https://github.com/apache/activemq-artemis/pull/5448#discussion_r1917226594
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPLargeMessage.java:
##########
@@ -660,7 +659,7 @@ public void referenceOriginalMessage(final Message
original, final SimpleString
super.referenceOriginalMessage(original, originalQueue);
- if (original instanceof LargeServerMessageImpl) {
+ if (original instanceof AMQPLargeMessage) {
Review Comment:
I'm not sure what else I could have meant but let me be more clear. What
will happen now that an AMQPLargeMessage cast would succeed when this method is
called? Should something have been testing this? From a brief look at the
broker code calling this it seems like the source message would never be
anything other than the AMQPLargeMessage itself so I doubt the cast to
ServerLargeMessageImpl would have succeeded in the past.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
