gemmellr commented on code in PR #5449: URL: https://github.com/apache/activemq-artemis/pull/5449#discussion_r1918567258
########## artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java: ########## @@ -658,6 +658,8 @@ public QueueImpl(final QueueConfiguration queueConfiguration, final QueueFactory factory) { super(server == null ? EmptyCriticalAnalyzer.getInstance() : server.getCriticalAnalyzer(), CRITICAL_PATHS); + Objects.requireNonNull(server); Review Comment: This makes the line above it a bit nonsensical and changing that might make this line redundant, depending on the approach taken. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact