gemmellr commented on PR #5459: URL: https://github.com/apache/activemq-artemis/pull/5459#issuecomment-2602216374
As you noticed, the broker already supports duplicate detection with AMQP messages, in the same general way it does for e.g Core and other protocol usages. This was added in some time ago, in ARTEMIS-2294. There are existing tests from that time, though I did just make and improvement to them. There isnt a specific note on the AMQP page for duplicate detection as it really notes behaviours specific to the AMQP support, whilst for duplicate detection the same general docs on duplicate detection apply to all the protocols and are a better fit. I did reorder and tweak the doc to emphasize the more general details first, before a note of the detail for just the Core Client. Both the tweaks I made are in https://github.com/apache/activemq-artemis/commit/89b3ebb077b203dd0c9ae3b85983d6b2ac1231e9 and I updated the Jira to reflect that, so I will close this PR out, but thanks for the contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
