gemmellr commented on code in PR #5450:
URL: https://github.com/apache/activemq-artemis/pull/5450#discussion_r1925139369
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ChannelImpl.java:
##########
@@ -698,7 +698,7 @@ public void transferConnection(final CoreRemotingConnection
newConnection) {
if (logger.isTraceEnabled()) {
logger.trace("RemotingConnectionID={} transferConnection to new
RemotingConnectionID={}",
- (connection == null ? "NULL" : connection.getID()),
+ connection.getID(),
Review Comment:
It would make sense to remove the check on the related line immediately
following this too, especially as _newConnection_ replaces _connection_, but
would be NPEd on in the next bit of code after this logging call before it can
happen. Perhaps could also add a newConnection null check at the start of the
method to make it more explicit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
